Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Console Definitions From Elasticsearch to Kibana for 7.9 #72556

Merged
merged 8 commits into from
Jul 31, 2020
Merged

Adding Console Definitions From Elasticsearch to Kibana for 7.9 #72556

merged 8 commits into from
Jul 31, 2020

Conversation

cuff-links
Copy link
Contributor

@cuff-links cuff-links commented Jul 21, 2020 •
edited by cjcenizal
Loading

Closes #71163
Closes #73060

Summary

This PR is to add Console Definitions to Kibana from ES' API.

@cuff-links cuff-links force-pushed the 7.9_Definitions_Update_For_Console branch from e50416b to 7101a10 Compare July 21, 2020 04:51
@cuff-links
Copy link
Contributor Author

@elasticmachine merge upstream

@cuff-links cuff-links added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 21, 2020
@cuff-links cuff-links force-pushed the 7.9_Definitions_Update_For_Console branch from bc5a843 to 27bf65f Compare July 21, 2020 22:32
@cuff-links
Copy link
Contributor Author

@elasticmachine merge upstream

@cuff-links cuff-links added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Jul 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cuff-links cuff-links requested a review from jloleysens July 21, 2020 22:45
@cuff-links cuff-links changed the title Adding definitions. Adding Console Definitions From Elasticsearch to Kibana for 7.9 Jul 22, 2020
@cjcenizal cjcenizal added Feature:Console Dev Tools Console Feature Feature:Dev Tools labels Jul 22, 2020
jloleysens
jloleysens reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cuff-links Thanks for updating these!

It would be great to hear from you on some of the comments below before merging. We could tackle adding "overrides" in a separate PR too, but I think doing them in one batch might just be simpler.

Let me know what you think!

src/plugins/console/server/lib/spec_definitions/json/generated/indices.put_index_template.json Show resolved Hide resolved
...gins/console/server/lib/spec_definitions/json/generated/indices.simulate_index_template.json Show resolved Hide resolved
src/plugins/console/server/lib/spec_definitions/json/generated/indices.simulate_template.json Show resolved Hide resolved
...gins/console/server/lib/spec_definitions/json/generated/indices.simulate_index_template.json Show resolved Hide resolved
@cuff-links
Copy link
Contributor Author

@cuff-links Thanks for updating these!

It would be great to hear from you on some of the comments below before merging. We could tackle adding "overrides" in a separate PR too, but I think doing them in one batch might just be simpler.

Let me know what you think!

I am definitely in favor of going ahead and getting this knocked out in a single PR. Working on these.

@cuff-links cuff-links requested a review from jloleysens July 23, 2020 18:22
@cuff-links
Copy link
Contributor Author

@elasticmachine merge upstream

@cuff-links cuff-links requested a review from cjcenizal July 29, 2020 00:03
@cuff-links
Copy link
Contributor Author

@jloleysens @cjcenizal Need the new changes reviewed so we can merge.

@cuff-links
Copy link
Contributor Author

@elasticmachine merge upstream

@cjcenizal cjcenizal mentioned this pull request Jul 30, 2020
Closed
cjcenizal
cjcenizal suggested changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I found some errors in the overrides. Once they're fixed I think we can merge.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cjcenizal
cjcenizal approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code LGTM!

@cuff-links cuff-links merged commit cc91e3d into elastic:7.9 Jul 31, 2020
@cuff-links cuff-links mentioned this pull request Sep 15, 2020
Closed
@mibragimov mibragimov mentioned this pull request Jan 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

@jloleysens jloleysens Awaiting requested review from jloleysens

Assignees
No one assigned
Labels
Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cuff-links @elasticmachine @kibanamachine @cjcenizal @jloleysens